6 Dec
2018
6 Dec
'18
9:48 p.m.
Patrick Georgi has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/29951 )
Change subject: util/qualcomm: Add T32 debug scripts ......................................................................
Patch Set 2:
(1 comment)
https://review.coreboot.org/#/c/29951/2/util/qualcomm/scripts/cmm/pbl32_to_b... File util/qualcomm/scripts/cmm/pbl32_to_bootblock64_jump.cmm:
https://review.coreboot.org/#/c/29951/2/util/qualcomm/scripts/cmm/pbl32_to_b... PS2, Line 16: are the multiple newlines near the end required? our style guide prefers us not to use such things (and that's where the Verified-1 comes from).
--
To view, visit https://review.coreboot.org/c/coreboot/+/29951
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I4e792a2806e5ebd3b4075c7bb69c43587920deae
Gerrit-Change-Number: 29951
Gerrit-PatchSet: 2
Gerrit-Owner: nsekar@codeaurora.org
Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org
Gerrit-CC: Patrick Georgi pgeorgi@google.com
Gerrit-Comment-Date: Thu, 06 Dec 2018 21:48:15 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment