Attention is currently required from: Raul Rangel, Marshall Dawson, Rob Barnes, Felix Held.
Kangheui Won has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/61369 )
Change subject: psp_verstage: report developer mode to PSP
......................................................................
Patch Set 1:
(1 comment)
File src/soc/amd/cezanne/psp_verstage/chipset.c:
https://review.coreboot.org/c/coreboot/+/61369/comment/a45a07ae_bc1e628d
PS1, Line 39: svc_set_platform_boot_mode(CHROME_BOOK_BOOT_MODE_DEVELOPER);
When is CHROME_BOOK_BOOT_MODE_UNSIGNED_VERSTAGE used?
The enum includes all internal states in the PSP. PSP set it to UNSIGNED_VERSTAGE and ignore this svc if verstage is not signed.
--
To view, visit
https://review.coreboot.org/c/coreboot/+/61369
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I04b5fcfa338b485b36f1b946203f32823385c0b1
Gerrit-Change-Number: 61369
Gerrit-PatchSet: 1
Gerrit-Owner: Kangheui Won
khwon@chromium.org
Gerrit-Reviewer: Felix Held
felix-coreboot@felixheld.de
Gerrit-Reviewer: Jason Glenesk
jason.glenesk@gmail.com
Gerrit-Reviewer: Marshall Dawson
marshalldawson3rd@gmail.com
Gerrit-Reviewer: Raul Rangel
rrangel@chromium.org
Gerrit-Reviewer: Rob Barnes
robbarnes@google.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-Attention: Raul Rangel
rrangel@chromium.org
Gerrit-Attention: Marshall Dawson
marshalldawson3rd@gmail.com
Gerrit-Attention: Rob Barnes
robbarnes@google.com
Gerrit-Attention: Felix Held
felix-coreboot@felixheld.de
Gerrit-Comment-Date: Sun, 30 Jan 2022 22:47:00 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Rob Barnes
robbarnes@google.com
Gerrit-MessageType: comment