Attention is currently required from: Forest Mittelberg, Jameson Thies.
Paul Menzel has posted comments on this change by Jameson Thies. ( https://review.coreboot.org/c/coreboot/+/84404?usp=email )
Change subject: chromeec/ec_acpi: Define ACPI devices for USB-C ports using UCSI
......................................................................
Patch Set 3: Code-Review+1
(2 comments)
Commit Message:
https://review.coreboot.org/c/coreboot/+/84404/comment/b6ff799e_8698d10e?usp... :
PS3, Line 15: we
are
https://review.coreboot.org/c/coreboot/+/84404/comment/69b72a58_de051b90?usp... :
PS3, Line 15: confirmed that there we ACPI devices for each USB-C port and
: cros_ec_ucsi correctly matched the ACPI devices.
Share the exact commands?
--
To view, visit
https://review.coreboot.org/c/coreboot/+/84404?usp=email
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings?usp=email
Gerrit-MessageType: comment
Gerrit-Project: coreboot
Gerrit-Branch: main
Gerrit-Change-Id: Ie7c281fe2a7fab705d3c238dcc4be68c93afd652
Gerrit-Change-Number: 84404
Gerrit-PatchSet: 3
Gerrit-Owner: Jameson Thies
jthies@google.com
Gerrit-Reviewer: Caveh Jalali
caveh@chromium.org
Gerrit-Reviewer: Forest Mittelberg
bmbm@google.com
Gerrit-Reviewer: Paul Menzel
paulepanter@mailbox.org
Gerrit-Reviewer: Subrata Banik
subratabanik@google.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Abhishek Pandit-Subedi
abhishekpandit@google.com
Gerrit-Attention: Jameson Thies
jthies@google.com
Gerrit-Attention: Forest Mittelberg
bmbm@google.com
Gerrit-Comment-Date: Wed, 25 Sep 2024 05:26:04 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes