Attention is currently required from: Philip Chen, zanxi chen, Bob Moragues, Julius Werner.
Xuxin Xiong has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/57329 )
Change subject: mb/google/trogdor: Add LCM_ID to SKU_ID
......................................................................
Patch Set 4:
(2 comments)
Patchset:
PS4:
We probably don't need extra strapping pins to identify panels.
If we use SKU ID to indentify different panel, it means each SKU can only support one of these two panels, it will impact the production and after sale.
PS4:
I am not sure that this is the correct way to handle this. […]
Mrbland has only one SKU now and supports two panels, INX and BOE. We hope these two panels can work normally in this SKU. Even if there are more SKUs in the future, we hope that these two panels can work normally in each SKU at the same time. If we use SKU ID to indentify different panel, it means each SKU can only support one of these two panels, it will impact the production and after sale.
--
To view, visit
https://review.coreboot.org/c/coreboot/+/57329
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I018b3f460f9d084d1a3f0dac026f1cd9dde284e2
Gerrit-Change-Number: 57329
Gerrit-PatchSet: 4
Gerrit-Owner: zanxi chen
chenzanxi@huaqin.corp-partner.google.com
Gerrit-Reviewer: Bob Moragues
moragues@chromium.org
Gerrit-Reviewer: Bob Moragues
moragues@google.com
Gerrit-Reviewer: Julius Werner
jwerner@chromium.org
Gerrit-Reviewer: Philip Chen
philipchen@google.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Weimin Wu
wuweimin@huaqin.corp-partner.google.com
Gerrit-CC: Wenli Xu
xuwenli@huaqin.corp-partner.google.com
Gerrit-CC: Xuxin Xiong
xuxinxiong@huaqin.corp-partner.google.com
Gerrit-Attention: Philip Chen
philipchen@google.com
Gerrit-Attention: zanxi chen
chenzanxi@huaqin.corp-partner.google.com
Gerrit-Attention: Bob Moragues
moragues@google.com
Gerrit-Attention: Julius Werner
jwerner@chromium.org
Gerrit-Attention: Bob Moragues
moragues@chromium.org
Gerrit-Comment-Date: Fri, 03 Sep 2021 01:57:16 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Philip Chen
philipchen@google.com
Comment-In-Reply-To: Bob Moragues
moragues@google.com
Gerrit-MessageType: comment