Jacob Garber has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/36081 )
Change subject: vendorcode/amd/agesa/f16kb/Proc/Mem/Feat/DMI: Cast to UINT64 to avoid overflow ......................................................................
Patch Set 2:
(3 comments)
https://review.coreboot.org/c/coreboot/+/36081/2//COMMIT_MSG Commit Message:
https://review.coreboot.org/c/coreboot/+/36081/2//COMMIT_MSG@7 PS2, Line 7: vendorcode/amd/agesa/f16kb/Proc/Mem/Feat/DMI This can be shortened to something like vc/amd/agesa/f16kb
https://review.coreboot.org/c/coreboot/+/36081/2//COMMIT_MSG@10 PS2, Line 10: UINT64_t UINT64 to be consistent.
https://review.coreboot.org/c/coreboot/+/36081/2/src/vendorcode/amd/agesa/f1... File src/vendorcode/amd/agesa/f16kb/Proc/Mem/Feat/DMI/mfDMI.c:
https://review.coreboot.org/c/coreboot/+/36081/2/src/vendorcode/amd/agesa/f1... PS2, Line 719: uint64_t Though the AGESA types are more ugly, it's probably better to use UINT64 for consistency.