Frans Hendriks has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/34666 )
Change subject: vendorcode/eltan/security/lib: Add missing vb2ex_printf()
......................................................................
Patch Set 2:
(1 comment)
https://review.coreboot.org/c/coreboot/+/34666/2/src/vendorcode/eltan/securi...
File src/vendorcode/eltan/security/lib/cb_vb2.c:
https://review.coreboot.org/c/coreboot/+/34666/2/src/vendorcode/eltan/securi...
PS2, Line 21: vb2ex_printf
Will that be redundant to src/security/vboot/vboot_logic. […]
Yes. My assumption was that including the vboot_logic.c would cause build errors, due too missing other includes.
Did some tests and noticed that using this vboot_logic.c (for bootblock only) works fine.
--
To view, visit
https://review.coreboot.org/c/coreboot/+/34666
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I3f649f3faf1e812d592e4981bc75698e2cad1cc8
Gerrit-Change-Number: 34666
Gerrit-PatchSet: 2
Gerrit-Owner: Frans Hendriks
fhendriks@eltan.com
Gerrit-Reviewer: Christian Walter
christian.walter@9elements.com
Gerrit-Reviewer: Felix Held
felix-coreboot@felixheld.de
Gerrit-Reviewer: Frans Hendriks
fhendriks@eltan.com
Gerrit-Reviewer: Lance Zhao
lance.zhao@gmail.com
Gerrit-Reviewer: Martin Roth
martinroth@google.com
Gerrit-Reviewer: Patrick Georgi
pgeorgi@google.com
Gerrit-Reviewer: Patrick Rudolph
siro@das-labor.org
Gerrit-Reviewer: Paul Menzel
paulepanter@users.sourceforge.net
Gerrit-Reviewer: Philipp Deppenwiese
zaolin.daisuki@gmail.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-Comment-Date: Mon, 05 Aug 2019 10:02:46 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Lance Zhao
lance.zhao@gmail.com
Gerrit-MessageType: comment