Kyösti Mälkki has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/31950 )
Change subject: device/pciexp_device: Add set_subsystem() for pciexp device ......................................................................
Patch Set 2:
(1 comment)
I was originally referring to eg soc/baytrail/chip.c where these functions are implemented using writes to config register (already defined) PCI_SUBSYSTEM_VENDOR_ID 0x2C. IMHO You can promote that to global space, like in device/pci.c.
It's not really tied to PCIe (or pciexp) thus keep the name as-is.
This should give you quite accurate list:
git grep --name-only "PCI_SUBSYSTEM_VENDOR_ID," -- src/ > files-to-fix sed -i -e "/PCI_SUBSYSTEM/ ,+2d" `cat files-to-fix` git add -e
With last one, tidy up the errors sed has left behind.
https://review.coreboot.org/#/c/31950/2/src/include/device/pciexp.h File src/include/device/pciexp.h:
https://review.coreboot.org/#/c/31950/2/src/include/device/pciexp.h@6 PS2, Line 6: #define PCIE_SUBSYSTEM_VENDOR_ID 0x94 Ah.. this register 0x94 seems to be specific to Intel, (unless of course you find it in the PCIe specifications defined like this for this purpose).
I like the work though, just that if this 0x94 is Intel specific, reflect it somehow in the names and put code under sb/intel/common instead of global space.