Kyösti Mälkki has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/31567 )
Change subject: soc/cavium/cn81xx: Enable RNG for DRAM init
......................................................................
Patch Set 2:
(1 comment)
https://review.coreboot.org/#/c/31567/2/src/soc/cavium/cn81xx/sdram.c
File src/soc/cavium/cn81xx/sdram.c:
https://review.coreboot.org/#/c/31567/2/src/soc/cavium/cn81xx/sdram.c@67
PS2, Line 67: /* Read back after enable so we know it is done. */
That's what the reference code does without further comments. […]
Sounds fun :(
Is it a small set of registesr or some known banks? I don't know the platform, are there any attributes to set "strong uncacheable memory" like x86 where memory writes cannot be combined or posted.
Do you know for sure PCI MMCONF space does not require reads after writes to sync things?
--
To view, visit
https://review.coreboot.org/c/coreboot/+/31567
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I886f920e9941793fb76b56cc5a24a42e23b082e0
Gerrit-Change-Number: 31567
Gerrit-PatchSet: 2
Gerrit-Owner: Patrick Rudolph
patrick.rudolph@9elements.com
Gerrit-Reviewer: David Hendricks
david.hendricks@gmail.com
Gerrit-Reviewer: David Hendricks
dhendrix.sync@gmail.com
Gerrit-Reviewer: Kyösti Mälkki
kyosti.malkki@gmail.com
Gerrit-Reviewer: Patrick Rudolph
patrick.rudolph@9elements.com
Gerrit-Reviewer: Philipp Deppenwiese
zaolin.daisuki@gmail.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Paul Menzel
paulepanter@users.sourceforge.net
Gerrit-Comment-Date: Tue, 26 Feb 2019 10:00:02 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Kyösti Mälkki
kyosti.malkki@gmail.com
Comment-In-Reply-To: Patrick Rudolph
patrick.rudolph@9elements.com
Gerrit-MessageType: comment