Ivan Vatlin has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/38143 )
Change subject: mb/asus/p5qc: Add ASUS P5Q as a variant ......................................................................
Patch Set 3:
(4 comments)
I really can't compare it for now, so here is dump from inteltool: https://pastebin.com/dB1RQa2B Also marked "done" all solved (IMHO) problems
https://review.coreboot.org/c/coreboot/+/38143/1//COMMIT_MSG Commit Message:
https://review.coreboot.org/c/coreboot/+/38143/1//COMMIT_MSG@7 PS1, Line 7: ASUS P5Q support and menu entries added
Guess I need to recommit my "work" :)
Done
https://review.coreboot.org/c/coreboot/+/38143/1//COMMIT_MSG@10 PS1, Line 10:
I haven't any exp w/ with Gerrit & Jenkins, so I guess it's only my fault
Done
https://review.coreboot.org/c/coreboot/+/38143/1/src/mainboard/asus/p5qc/Kco... File src/mainboard/asus/p5qc/Kconfig:
https://review.coreboot.org/c/coreboot/+/38143/1/src/mainboard/asus/p5qc/Kco... PS1, Line 55: config GPIO_C
The GPIO settings might be different for the Asus P5Q. […]
Here is GPIO registers: https://pastebin.com/dB1RQa2B
https://review.coreboot.org/c/coreboot/+/38143/1/src/mainboard/asus/p5qc/var... File src/mainboard/asus/p5qc/variants/p5q/devicetree.cb:
PS1:
I copypasted the device tree from "p5qc/" variant for any possible future work but guess they right […]
Done