[coreboot-gerrit] Change in coreboot[master]: soc/intel/cannonlake: Drop unnecessary guard for HECI1 disable FSP UPD

[Sridhar Siricilla (Code Review)]

Attention is currently required from: Subrata Banik, Maulik V Vaghela, Tim Wawrzynczak, Angel Pons, Nick Vaccaro, Patrick Rudolph, EricR Lai.
Sridhar Siricilla has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/61455 )

Change subject: soc/intel/cannonlake: Drop unnecessary guard for HECI1 disable FSP UPD
......................................................................

Patch Set 4:

(1 comment)

File src/soc/intel/cannonlake/fsp_params.c:

https://review.coreboot.org/c/coreboot/+/61455/comment/93f4f52f_4c8a07ff 
PS3, Line 589: Heci1
> > Writing Heci1 in the code should be ok, but comment should be HECI1!  WDYT?  […]
>
> Don't know about any rule thats support this argument "Writing Heci1 in the code should be ok, but comment should be HECI1!". If you are specific about following the acronym then why not adhere the same all across in my point.

Agree with you, we should maintain consistency across all places to avoid confusion.  As you know coding rules applicable when choosing a identifier name, hence heci1 (but I mentioned Heci1 😞 ) usage should be fine in the code.

IMO, heci or HECI (good to refer) should be fine in the comments, but Heci1 is something not preferable over others!
> Also, if I just look for your recommendation then also there are ample conflicts. I would prefer to have action that unifies those as well.

Once your patches are landed in the upstream, I will push CL to update the references to words "Heci" and "heci".