Attention is currently required from: Hung-Te Lin, Paul Menzel, Yu-Ping Wu. flora.fu@mediatek.com has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/58969 )
Change subject: soc/mediatek/mt8195: Add APU device apc driver ......................................................................
Patch Set 6:
(6 comments)
Commit Message:
https://review.coreboot.org/c/coreboot/+/58969/comment/aa46fccb_407ad731 PS2, Line 13: TEST=boot cherry correctly
Please paste the new debug messages, added by the code.
Done, Thanks for the review
File src/soc/mediatek/mt8195/include/soc/apusys_devapc_def.h:
https://review.coreboot.org/c/coreboot/+/58969/comment/490f3c7c_642066ba PS2, Line 13: 0x1000
Why use 0x1000 instead of 1 for errors? Are these values copied from somewhere?
Actually, it is the legacy error codes that we usually use for APU dapc.
https://review.coreboot.org/c/coreboot/+/58969/comment/97be29a5_973072df PS2, Line 23: APUSYS_APC_PERM_TYPE
Lower case name.
Done
https://review.coreboot.org/c/coreboot/+/58969/comment/8afce209_edc7b4c4 PS2, Line 31: APUSYS_APC_DOMAIN_ID
Lower case name.
Done
https://review.coreboot.org/c/coreboot/+/58969/comment/07071157_4ccf1528 PS2, Line 50: APC_DOM_16
Lower case name.
Done
https://review.coreboot.org/c/coreboot/+/58969/comment/c8658030_3ea859e5 PS2, Line 51: unsigned char d0_permission; : unsigned char d1_permission; : unsigned char d2_permission; : unsigned char d3_permission; : unsigned char d4_permission; : unsigned char d5_permission; : unsigned char d6_permission; : unsigned char d7_permission; : unsigned char d8_permission; : unsigned char d9_permission; : unsigned char d10_permission; : unsigned char d11_permission; : unsigned char d12_permission; : unsigned char d13_permission; : unsigned char d14_permission; : unsigned char d15_permission;
Why not use an array? […]
Done