Furquan Shaikh has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/39313 )
Change subject: soc/intel/tigerlake: Correct order of "RUN_FSP_GOP" check ......................................................................
Patch Set 4:
(1 comment)
https://review.coreboot.org/c/coreboot/+/39313/3/src/soc/intel/tigerlake/gra... File src/soc/intel/tigerlake/graphics.c:
https://review.coreboot.org/c/coreboot/+/39313/3/src/soc/intel/tigerlake/gra... PS3, Line 69: } I am not convinced this is correct. At least in the past, this had to be done to ensure that the kernel can use 4-lane eDP in verified boot mode i.e. when GOP does not execute. In fact, your comment above already says that: "This will allow the kernel to use 4-lane eDP links properly if the VBIOS or GOP driver do not execute.". I am not sure how the latest kernel behaves, but if the behavior is still the same on kernel side, then by making this change, you will be impacting verified mode where GOP does not execute.
we observed hang when Display is not connected in JSL.
Where does the hang occur? In coreboot? In FSP? Have you debugged what operation is causing that hang? And is this a hard hang? an assert?