EricR Lai has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/41712 )
Change subject: soc/intel/common: Add restore and enable GPIO PM
......................................................................
Patch Set 4:
(1 comment)
https://review.coreboot.org/c/coreboot/+/41712/4/src/soc/intel/common/acpi/g...
File src/soc/intel/common/acpi/gpio.asl:
https://review.coreboot.org/c/coreboot/+/41712/4/src/soc/intel/common/acpi/g...
PS4, Line 22: Name(GPMB, Package(TOTAL_GPIO_COMM) {0})
No error. And I can print it by Printf ("%o", GPMB(Local0)), totally fine though.
@Tim, here is the ACPI spec:
Example 3: This code allocates space for ten objects to be defined at runtime (see the Name and
Index term definitions).
Package (10) {}
Example 4: These package declarations will cause the compiler to emit a VarPackageOp AML
opcode.
Name (SIZE, 4)
Package (SIZE) {}
Package (1024) {}
Package (256) {}
This will be treated as runtime var, so I think I can remove the 0 and this won't confuse others.
--
To view, visit
https://review.coreboot.org/c/coreboot/+/41712
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: If5e4553d568a872de234a2d671118acbae0a6159
Gerrit-Change-Number: 41712
Gerrit-PatchSet: 4
Gerrit-Owner: EricR Lai
ericr_lai@compal.corp-partner.google.com
Gerrit-Reviewer: Aamir Bohra
aamir.bohra@intel.com
Gerrit-Reviewer: Bernardo Perez Priego
bernardo.perez.priego@intel.corp-partner.google.com
Gerrit-Reviewer: Bora Guvendik
bora.guvendik@intel.corp-partner.google.com
Gerrit-Reviewer: Duncan Laurie
dlaurie@chromium.org
Gerrit-Reviewer: Furquan Shaikh
furquan@google.com
Gerrit-Reviewer: Patrick Rudolph
siro@das-labor.org
Gerrit-Reviewer: Selma Bensaid
selma.bensaid@intel.corp-partner.google.com
Gerrit-Reviewer: Subrata Banik
subrata.banik@intel.com
Gerrit-Reviewer: Tim Wawrzynczak
twawrzynczak@chromium.org
Gerrit-Reviewer: Venkata Krishna Nimmagadda
Venkata.krishna.nimmagadda@intel.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Paul Menzel
paulepanter@users.sourceforge.net
Gerrit-Comment-Date: Thu, 28 May 2020 15:43:33 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Tim Wawrzynczak
twawrzynczak@chromium.org
Comment-In-Reply-To: EricR Lai
ericr_lai@compal.corp-partner.google.com
Gerrit-MessageType: comment