Varshit B Pandya has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/42679 )
Change subject: mb/google/dedede: Update link frequency and end point structure for OV9734
......................................................................
Patch Set 5:
(2 comments)
https://review.coreboot.org/c/coreboot/+/42679/4/src/mainboard/google/dedede...
File src/mainboard/google/dedede/variants/baseboard/include/baseboard/acpi/cam0.asl:
https://review.coreboot.org/c/coreboot/+/42679/4/src/mainboard/google/dedede...
PS4, Line 142: Package (0x05)
FYI you can just use `Package ()` in ASL files, and iasl will fill in the appropriate length
Ack
https://review.coreboot.org/c/coreboot/+/42679/4/src/mainboard/google/dedede...
PS4, Line 170: 0xABA9500
I think this is much clearer when using decimal (180000000), could we do that instead?
Done
--
To view, visit
https://review.coreboot.org/c/coreboot/+/42679
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I164cb6af1003de561be8ce640e7653b7bcb3a22f
Gerrit-Change-Number: 42679
Gerrit-PatchSet: 5
Gerrit-Owner: Varshit B Pandya
varshit.b.pandya@intel.com
Gerrit-Reviewer: Aamir Bohra
aamir.bohra@intel.com
Gerrit-Reviewer: Furquan Shaikh
furquan@google.com
Gerrit-Reviewer: Karthik Ramasubramanian
kramasub@google.com
Gerrit-Reviewer: Maulik V Vaghela
maulik.v.vaghela@intel.com
Gerrit-Reviewer: Rizwan Qureshi
rizwan.qureshi@intel.com
Gerrit-Reviewer: Ronak Kanabar
ronak.kanabar@intel.com
Gerrit-Reviewer: Tim Wawrzynczak
twawrzynczak@chromium.org
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Paul Menzel
paulepanter@users.sourceforge.net
Gerrit-Comment-Date: Thu, 16 Jul 2020 16:24:00 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Tim Wawrzynczak
twawrzynczak@chromium.org
Gerrit-MessageType: comment