Attention is currently required from: Felix Singer, Filip Lewiński, Krystian Hebel, Maciej Pijanowski, Martin L Roth, Michał Kopeć, Paul Menzel.
Matt DeVillier has posted comments on this change by Filip Lewiński. ( https://review.coreboot.org/c/coreboot/+/83385?usp=email )
Change subject: payloads/external/iPXE/Makefile: Build iPXE for EFI target if requested
......................................................................
Patch Set 3:
(3 comments)
File payloads/external/iPXE/Kconfig:
https://review.coreboot.org/c/coreboot/+/83385/comment/8bd08e88_b393641d?usp... :
PS3, Line 119: config IPXE_BUILD_EFI
Please make that a choice menu, so the difference between EFI and non-EFI is clear.
disagree, a choice is unnecessary here when there are only two options. The help text could elaborate though that not selecting the option means it is being built for legacy BIOS
https://review.coreboot.org/c/coreboot/+/83385/comment/8cb660ff_6eec5138?usp... :
PS3, Line 121: default n
do we want this to depend on PAYLOAD_EDK2, or do we want it to be able to be built separately?
https://review.coreboot.org/c/coreboot/+/83385/comment/a6583809_da0b4f80?usp... :
PS3, Line 123: Build iPXE for EFI target, enabling it to be executed from EDK2.
Does EDK2 support loading it from CBFS?
no, edk2 has no concept of CBFS, only the FVs (firmware volume) created as part of its build
--
To view, visit
https://review.coreboot.org/c/coreboot/+/83385?usp=email
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings?usp=email
Gerrit-MessageType: comment
Gerrit-Project: coreboot
Gerrit-Branch: main
Gerrit-Change-Id: I7f247a59a65aeb18a67475d4d543f519af88aeb9
Gerrit-Change-Number: 83385
Gerrit-PatchSet: 3
Gerrit-Owner: Filip Lewiński
filip.lewinski@3mdeb.com
Gerrit-Reviewer: Krystian Hebel
krystian.hebel@3mdeb.com
Gerrit-Reviewer: Maciej Pijanowski
maciej.pijanowski@3mdeb.com
Gerrit-Reviewer: Martin L Roth
gaumless@gmail.com
Gerrit-Reviewer: Michał Kopeć
michal.kopec@3mdeb.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Felix Singer
service+coreboot-gerrit@felixsinger.de
Gerrit-CC: Matt DeVillier
matt.devillier@gmail.com
Gerrit-CC: Michał Żygowski
michal.zygowski@3mdeb.com
Gerrit-CC: Paul Menzel
paulepanter@mailbox.org
Gerrit-Attention: Felix Singer
service+coreboot-gerrit@felixsinger.de
Gerrit-Attention: Maciej Pijanowski
maciej.pijanowski@3mdeb.com
Gerrit-Attention: Martin L Roth
gaumless@gmail.com
Gerrit-Attention: Filip Lewiński
filip.lewinski@3mdeb.com
Gerrit-Attention: Paul Menzel
paulepanter@mailbox.org
Gerrit-Attention: Michał Kopeć
michal.kopec@3mdeb.com
Gerrit-Attention: Krystian Hebel
krystian.hebel@3mdeb.com
Gerrit-Comment-Date: Thu, 25 Jul 2024 14:08:58 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Felix Singer
service+coreboot-gerrit@felixsinger.de
Comment-In-Reply-To: Paul Menzel
paulepanter@mailbox.org