Nikolai Vyssotski has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/46840 )
Change subject: soc/amd/picasso: Update coreboot UPD variable names to include units ......................................................................
Patch Set 5: Code-Review+1
(2 comments)
Some nits: we can remove leftover comments now
https://review.coreboot.org/c/coreboot/+/46840/4/src/mainboard/google/zork/v... File src/mainboard/google/zork/variants/baseboard/devicetree_trembyle.cb:
https://review.coreboot.org/c/coreboot/+/46840/4/src/mainboard/google/zork/v... PS4, Line 26: register "vddcr_soc_voltage_margin_mV" = "0" #mV : register "vddcr_vdd_voltage_margin_mV" = "0" #mV : #mV is not needed now
https://review.coreboot.org/c/coreboot/+/46840/5/src/mainboard/google/zork/v... File src/mainboard/google/zork/variants/vilboz/overridetree.cb:
https://review.coreboot.org/c/coreboot/+/46840/5/src/mainboard/google/zork/v... PS5, Line 13: register "slow_ppt_limit_mW" = "6000" # mW we can remove superfluous comments now