Attention is currently required from: Arthur Heymans, Jakub Czapiga, Martin L Roth.
Felix Singer has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/80063?usp=email )
Change subject: Makefiles: Rename top-level Makefiles from .inc to .mk ......................................................................
Patch Set 3:
(1 comment)
Commit Message:
https://review.coreboot.org/c/coreboot/+/80063/comment/99cc6401_905be9d3 : PS2, Line 10: This means that editors don't recognize the files, and don't : open them with highlighting and any other specific editor functionality. :
I wrote a script that adjusts everything. Will update shortly.
I updated the changes until CB:80129. While rebasing CB:80103, there was an one-line conflict that I needed to resolve manually, but otherwise this script worked very well 😄
If anyone is interested:
``` #!/usr/bin/env bash
# This function is ran in a while-loop per commit. See below. function black_magic() { # Get list of changed files changed_files="$( git show --name-only --oneline | tail -n +2 )"
# Adjust file extensions in modified files sed -i'' 's/.mak/.mk/g' ${changed_files}
# To make things not overly complicated, # save changes done so far and adjust file # extensions in commit messages. commit_message="$( git log --format=%B -n 1 | sed 's/.mak/.mk/g' )" git add ${changed_files} git commit --amend -m "${commit_message}"
# Rename files from .mak to .mk for file in ${changed_files}; do # Filter out files with no extension [[ $file == *.mak ]] || continue destdir="$(dirname ${file})" filename="$(basename ${file} .mak)" git mv "${file}" "${destdir}/${filename}.mk" done
# Save again git commit --amend --no-edit }
black_magic while true; do git rebase --continue || exit 1 black_magic done ```