Attention is currently required from: YH Lin, Paul Menzel, Tim Wawrzynczak.
Joey Peng has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/62952 )
Change subject: mb/google/brya/var/taniks: Increase TSR2 threshold from 40 °C to 70 °C
......................................................................
Patch Set 3:
(3 comments)
Commit Message:
https://review.coreboot.org/c/coreboot/+/62952/comment/f8d0d49c_fb3c9a41
PS1, Line 7: /mb/google/brya/var/taniks: Modify DPTF setting for taniks
Please write something like: […]
Done
https://review.coreboot.org/c/coreboot/+/62952/comment/2c087786_4343c904
PS1, Line 7: /
please remove leading slash
Done
https://review.coreboot.org/c/coreboot/+/62952/comment/d3877185_401e285c
PS1, Line 12: TEST=build and tested on taniks board
Tested how? Just booted or ran some benchmark?
Updated test method.
--
To view, visit
https://review.coreboot.org/c/coreboot/+/62952
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I567815782ece4ab7fcec7da6b787ee9eec27aba4
Gerrit-Change-Number: 62952
Gerrit-PatchSet: 3
Gerrit-Owner: Joey Peng
joey.peng@lcfc.corp-partner.google.com
Gerrit-Reviewer: Tim Wawrzynczak
twawrzynczak@chromium.org
Gerrit-Reviewer: YH Lin
yueherngl@google.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Jerry2 Huang
jerry2.huang@lcfc.corp-partner.google.com
Gerrit-CC: Kevin Chang
kevin.chang@lcfc.corp-partner.google.com
Gerrit-CC: Paul Menzel
paulepanter@mailbox.org
Gerrit-CC: Sunshine Chao
sunshine.chao@lcfc.corp-partner.google.com
Gerrit-Attention: YH Lin
yueherngl@google.com
Gerrit-Attention: Paul Menzel
paulepanter@mailbox.org
Gerrit-Attention: Tim Wawrzynczak
twawrzynczak@chromium.org
Gerrit-Comment-Date: Tue, 22 Mar 2022 02:20:25 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Paul Menzel
paulepanter@mailbox.org
Comment-In-Reply-To: Tim Wawrzynczak
twawrzynczak@chromium.org
Gerrit-MessageType: comment