Attention is currently required from: Patrick Georgi, Tim Wawrzynczak, Julius Werner. Raul Rangel has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/60018 )
Change subject: cbfstool: Do host space address conversion earlier when adding files ......................................................................
Patch Set 2:
(3 comments)
Commit Message:
https://review.coreboot.org/c/coreboot/+/60018/comment/6f036f10_1c15dc9c PS2, Line 23: no effect Can we remove it from the Makefiles?
File util/cbfstool/cbfstool.c:
https://review.coreboot.org/c/coreboot/+/60018/comment/e71a123f_6dfa8c9c PS2, Line 1074: 4*1024; Just curious if you know why the 4K requirement?
https://review.coreboot.org/c/coreboot/+/60018/comment/c68dcb21_c66c189e PS2, Line 1078: offset Isn't `address` supposed to contain a host based address so it can perform the relocation?