Attention is currently required from: Paul Menzel, Angel Pons, Patrick Rudolph. Matt DeVillier has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/58188 )
Change subject: nb/intel/sandybridge: Populate meminfo when using MRC ......................................................................
Patch Set 4:
(13 comments)
Commit Message:
https://review.coreboot.org/c/coreboot/+/58188/comment/4abc6698_4c571fe7 PS1, Line 7: nb/sandybridge:add CBMEM_MEMINFO table when initing RAM
How about: […]
Done
https://review.coreboot.org/c/coreboot/+/58188/comment/87b3a441_b186d9fb PS1, Line 9: Populate a memory_info struct with PEI and SPD data, : in order to inject the CBMEM_INFO table necessary to : populate a type17 SMBIOS table.
It’d be great, if you reflowed this for 72/75 characters per line.
Done
https://review.coreboot.org/c/coreboot/+/58188/comment/228f78c1_5a080e8f PS1, Line 14: SandyBridge
Nit: Sandy Bridge
Done
https://review.coreboot.org/c/coreboot/+/58188/comment/62b15cbe_4f808a0a PS1, Line 17:
remove one space
Done
File src/northbridge/intel/sandybridge/raminit_mrc.c:
https://review.coreboot.org/c/coreboot/+/58188/comment/e7fd41d8_1b178590 PS1, Line 392: struct memory_info* mem_info;
"foo* bar" should be "foo *bar" […]
Done
https://review.coreboot.org/c/coreboot/+/58188/comment/aa42276e_d3a5ae9c PS1, Line 406: ddr_frequency
See raminit_shared.c on how to calculate this, the reference clock can be 133 MHz or 100 MHz.
Done
https://review.coreboot.org/c/coreboot/+/58188/comment/70b88ff9_d3ae8f11 PS1, Line 406: /
please add spaces around `/`. Or even better, use `DIV_ROUND_CLOSEST`.
Done
https://review.coreboot.org/c/coreboot/+/58188/comment/78c70e3e_93b3eaf0 PS1, Line 411: // DIMM-A
I'd much prefer C-style comments, for consistency with the rest of the file.
Done
https://review.coreboot.org/c/coreboot/+/58188/comment/b884c392_817abfd5 PS1, Line 422: memcpy(dimm->serial, // bytes 122-125 in SPD
please, no space before tabs […]
Done
https://review.coreboot.org/c/coreboot/+/58188/comment/96c4fb69_b6cd6f83 PS1, Line 428: dimm->mod_id = // bytes 117/118 (LSB/MSB)
line over 96 characters […]
Done
https://review.coreboot.org/c/coreboot/+/58188/comment/fb9cb4a9_ed365e43 PS1, Line 446: memcpy(dimm->serial, // bytes 122-125 in SPD
please, no space before tabs […]
Done
https://review.coreboot.org/c/coreboot/+/58188/comment/20155507_25b79f6d PS1, Line 452: dimm->mod_id = // bytes 117/118 (LSB/MSB)
please, no space before tabs […]
Done
https://review.coreboot.org/c/coreboot/+/58188/comment/efe5f98a_f2dbea10 PS1, Line 452: dimm->mod_id = // bytes 117/118 (LSB/MSB)
line over 96 characters […]
Done