Damien Zammit has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/37872 )
Change subject: biostar/a68n_5200: Switch away from ROMCC_BOOTBLOCK
......................................................................
Patch Set 16:
(1 comment)
Patchset 15 LGTM, 16 has an unnecessary modified copyright notice.
https://review.coreboot.org/c/coreboot/+/37872/14/src/mainboard/biostar/a68n...
File src/mainboard/biostar/a68n_5200/bootblock.c:
https://review.coreboot.org/c/coreboot/+/37872/14/src/mainboard/biostar/a68n...
PS14, Line 6: 2020
That's not your decision to make.
The first few drafts of this change removed the copyright notices entirely, and was missing parts of the SIO init. I only added 2020 because I thought it was different to the original.
Considering it's merely a copy paste from the original I am fine with not changing the copyright notice.
--
To view, visit
https://review.coreboot.org/c/coreboot/+/37872
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I2e710ac61843c09a055523c7971e4c05bae56a37
Gerrit-Change-Number: 37872
Gerrit-PatchSet: 16
Gerrit-Owner: Mike Banon
mikebdp2@gmail.com
Gerrit-Reviewer: Damien Zammit
Gerrit-Reviewer: Edward O'Callaghan
quasisec@chromium.org
Gerrit-Reviewer: HAOUAS Elyes
ehaouas@noos.fr
Gerrit-Reviewer: Kyösti Mälkki
kyosti.malkki@gmail.com
Gerrit-Reviewer: Martin Roth
martinroth@google.com
Gerrit-Reviewer: Mike Banon
mikebdp2@gmail.com
Gerrit-Reviewer: Patrick Georgi
pgeorgi@google.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Nico Huber
nico.h@gmx.de
Gerrit-CC: Paul Menzel
paulepanter@users.sourceforge.net
Gerrit-Comment-Date: Mon, 20 Jan 2020 08:49:16 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Mike Banon
mikebdp2@gmail.com
Comment-In-Reply-To: Nico Huber
nico.h@gmx.de
Gerrit-MessageType: comment