Attention is currently required from: Felix Singer, Martin L Roth, Patrick Rudolph, Subrata Banik, Stefan Reinauer, Kapil Porwal, Maximilian Brune, Angel Pons, Lean Sheng Tan.
Matt DeVillier has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/74692 )
Change subject: Revert "util/ifdtool: Add option to create FMAP template" ......................................................................
Patch Set 2:
(1 comment)
Commit Message:
https://review.coreboot.org/c/coreboot/+/74692/comment/e44b60ca_665a0dfb PS2, Line 11: Above commit inserts multiple IFD regions not present into the default : FMAP template, some of which overlap, resulting in far less space : available for BIOS region / CBFS.
Did you have issues with an IFD on a board? Was the IFD faulty somehow?
I'm having issues building all of the google/glados variants (Skylake). This is what the generated fmap.fmd ends up being:
FLASH@4278190080 0x01000000 { SI_DESC@0x0 0x1000 SI_ME@0x1000 0x1FF000 SI_IE@0x7FFF000 0x1000 SI_10GBE0@0x7FFF000 0x1000 SI_10GBE1@0x7FFF000 0x1000 (null)@0x7FFF000 0x1000 (null)@0x7FFF000 0x1000 SI_PTT@0x7FFF000 0x1000 SI_BIOS@12255232 4521984 { RW_MRC_CACHE@0 0x10000 SMMSTORE@65536 0x40000 RO_VPD@327680 0x4000 FMAP@344064 0x200 COREBOOT(CBFS)@344576 4177408 } }
the error I get building is:
FMAP build/util/cbfstool/fmaptool -h build/fmap_config.h build/fmap.fmd build/fmap.fmap syntax error FATAL: Failed while processing provided descriptor
it seems possible this is an issue with ifdtool, since using the `-p sklkbl` flag produces a layout with those bogus fields. Running ifdtool without `-p` shows the correct layout:
without -p:
Found Region Section FLREG0: 0x00000000 Flash Region 0 (Flash Descriptor): 00000000 - 00000fff FLREG1: 0x0fff0200 Flash Region 1 (BIOS): 00200000 - 00ffffff FLREG2: 0x01ff0001 Flash Region 2 (Intel ME): 00001000 - 001fffff FLREG3: 0x00007fff Flash Region 3 (GbE): 00fff000 - 00000fff (unused) FLREG4: 0x00007fff Flash Region 4 (Platform Data): 00fff000 - 00000fff (unused)
with -p sklkbl (which is what the build system is doing):
Found Region Section FLREG0: 0x00000000 Flash Region 0 (Flash Descriptor): 00000000 - 00000fff FLREG1: 0x0fff0200 Flash Region 1 (BIOS): 00200000 - 00ffffff FLREG2: 0x01ff0001 Flash Region 2 (Intel ME): 00001000 - 001fffff FLREG3: 0x00007fff Flash Region 3 (GbE): 07fff000 - 00000fff (unused) FLREG4: 0x00007fff Flash Region 4 (Platform Data): 07fff000 - 00000fff (unused) FLREG5: 0x00007fff Flash Region 5 (Device Exp1): 07fff000 - 00000fff (unused) FLREG6: 0x00007fff Flash Region 6 (Secondary BIOS): 07fff000 - 00000fff (unused) FLREG8: 0x00007fff Flash Region 8 (EC): 07fff000 - 00000fff (unused) FLREG9: 0x00007fff Flash Region 9 (Device Exp2): 07fff000 - 00000fff (unused) FLREG10: 0xffffffff Flash Region 10 (IE): 07fff000 - 07ffffff FLREG11: 0xffffffff Flash Region 11 (10GbE_0): 07fff000 - 07ffffff FLREG12: 0xffffffff Flash Region 12 (10GbE_1): 07fff000 - 07ffffff FLREG13: 0xffffffff Flash Region 13 (Reserved): 07fff000 - 07ffffff FLREG14: 0xffffffff Flash Region 14 (Reserved): 07fff000 - 07ffffff FLREG15: 0xffffffff Flash Region 15 (PTT): 07fff000 - 07ffffff