Hung-Te Lin has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/36090 )
Change subject: soc/mediatek/mt8183: Force DRAM retraining if hotkey pressed ......................................................................
Patch Set 2:
(2 comments)
https://review.coreboot.org/c/coreboot/+/36090/2/src/soc/mediatek/mt8183/mem... File src/soc/mediatek/mt8183/memory.c:
https://review.coreboot.org/c/coreboot/+/36090/2/src/soc/mediatek/mt8183/mem... PS2, Line 170: const bool force_retrain = get_recovery_mode_retrain_switch(); again, the chromeos/vboot specific logic should live only in mainboard/romstage.c, and passed here.
(or, we can also wipe cache there).
https://review.coreboot.org/c/coreboot/+/36090/2/src/soc/mediatek/mt8183/mem... PS2, Line 175: 0 0xff