Aaron Durbin has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/31762 )
Change subject: arch/x86/postcar: Add separate timestamp for postcar stage ......................................................................
Patch Set 1:
(1 comment)
https://review.coreboot.org/#/c/31762/1/src/arch/x86/postcar_loader.c File src/arch/x86/postcar_loader.c:
https://review.coreboot.org/#/c/31762/1/src/arch/x86/postcar_loader.c@178 PS1, Line 178: timestamp_add_now(TS_START_POSTCAR);
you should comment/document such notions.
I will add some comment to note that point.
new timestamp that is essentially "about to start" vs "actually started", but we can read between the lines as to what is happening there.
I will name may be "Starting of postcar" and "end of postcar" to make thinks consistent across ?
I was commenting about how the current usage is actually done for romstage and ramstage. I would expect to see a similar pattern for postcar, but this CL doesn't do that.