Attention is currently required from: Cliff Huang, Dinesh Gehlot, Eran Mitrani, Jakub Czapiga, Jayvik Desai, Kapil Porwal, Nick Vaccaro, Rishika Raj, Tarun.
Subrata Banik has posted comments on this change by Cliff Huang. ( https://review.coreboot.org/c/coreboot/+/83980?usp=email )
Change subject: soc/intel/common/tcss: Move AUX bias ctrl register field defines to TCSS SOC header
......................................................................
Patch Set 1:
(3 comments)
Commit Message:
https://review.coreboot.org/c/coreboot/+/83980/comment/8ee1ebda_649b0359?usp... :
PS1, Line 6:
`Possible long commit subject (prefer a maximum 65 characters)`
Please fix.
https://review.coreboot.org/c/coreboot/+/83980/comment/5f7e18f3_2a36747d?usp... :
PS1, Line 8:
please specify the motivation behind this migration
https://review.coreboot.org/c/coreboot/+/83980/comment/7b4f937e_a0af0306?usp... :
PS1, Line 9: These field defines are SOC-specific.
```
BUG=
TEST=
```
--
To view, visit
https://review.coreboot.org/c/coreboot/+/83980?usp=email
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings?usp=email
Gerrit-MessageType: comment
Gerrit-Project: coreboot
Gerrit-Branch: main
Gerrit-Change-Id: I0f9c895590465b2f539c91834cf331fcd7efa996
Gerrit-Change-Number: 83980
Gerrit-PatchSet: 1
Gerrit-Owner: Cliff Huang
cliff.huang@intel.com
Gerrit-Reviewer: Dinesh Gehlot
digehlot@google.com
Gerrit-Reviewer: Eran Mitrani
mitrani@google.com
Gerrit-Reviewer: Jakub Czapiga
czapiga@google.com
Gerrit-Reviewer: Jayvik Desai
jayvik@google.com
Gerrit-Reviewer: Kapil Porwal
kapilporwal@google.com
Gerrit-Reviewer: Nick Vaccaro
nvaccaro@chromium.org
Gerrit-Reviewer: Rishika Raj
rishikaraj@google.com
Gerrit-Reviewer: Subrata Banik
subratabanik@google.com
Gerrit-Reviewer: Tarun
tstuli@gmail.com
Gerrit-CC: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-Attention: Jayvik Desai
jayvik@google.com
Gerrit-Attention: Cliff Huang
cliff.huang@intel.com
Gerrit-Attention: Rishika Raj
rishikaraj@google.com
Gerrit-Attention: Eran Mitrani
mitrani@google.com
Gerrit-Attention: Jakub Czapiga
czapiga@google.com
Gerrit-Attention: Kapil Porwal
kapilporwal@google.com
Gerrit-Attention: Dinesh Gehlot
digehlot@google.com
Gerrit-Attention: Nick Vaccaro
nvaccaro@chromium.org
Gerrit-Attention: Tarun
tstuli@gmail.com
Gerrit-Comment-Date: Mon, 19 Aug 2024 17:07:31 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No