Attention is currently required from: Eric Lai, Jon Murphy, Karthik Ramasubramanian, Martin Roth.
Tim Van Patten has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/75583?usp=email )
Change subject: mb/google/myst: Add PCIe shutdown workaround ......................................................................
Patch Set 2:
(2 comments)
File src/mainboard/google/myst/port_descriptors.c:
https://review.coreboot.org/c/coreboot/+/75583/comment/b8d61c2f_39fd8315 : PS2, Line 56: .turn_off_unused_lanes = true, Can we toggle this to `false` instead, assuming that also fixes it? It seems like a more direct approach to what you're trying to achieve here, based on the description:
https://source.corp.google.com/chromeos_public/src/third_party/coreboot/src/...
``` uint32_t turn_off_unused_lanes :1; // Power down lanes if device not present ```
https://review.coreboot.org/c/coreboot/+/75583/comment/74c0d345_346d57f3 : PS2, Line 57: /284213391 nit: b/284213391 (missing the 'b'), for both of these