Jacob Garber has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/34573 )
Change subject: mb/asus/kfsn4-dre: Return early if CK804 not found
......................................................................
Patch Set 1:
Patch Set 1: Code-Review+1
Can the board work at all if this fails? Maybe the log level above should also be raised from warning to error.
I'm not sure, probably not. In that case we could probably just die() instead.
--
To view, visit
https://review.coreboot.org/c/coreboot/+/34573
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I13c663314496caf51a57da7f27f9ea24e3d7fcbd
Gerrit-Change-Number: 34573
Gerrit-PatchSet: 1
Gerrit-Owner: Jacob Garber
jgarber1@ualberta.ca
Gerrit-Reviewer: Angel Pons
th3fanbus@gmail.com
Gerrit-Reviewer: David Hendricks
david.hendricks@gmail.com
Gerrit-Reviewer: Jacob Garber
jgarber1@ualberta.ca
Gerrit-Reviewer: Martin Roth
martinroth@google.com
Gerrit-Reviewer: Patrick Georgi
pgeorgi@google.com
Gerrit-Reviewer: Paul Menzel
paulepanter@users.sourceforge.net
Gerrit-Reviewer: Timothy Pearson
tpearson@raptorengineering.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-Comment-Date: Fri, 26 Jul 2019 18:58:19 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: No
Gerrit-MessageType: comment