Arthur Heymans has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/35864 )
Change subject: mb/lenovo/{t60,r60}: Add ThinkPad R60 support as variant board ......................................................................
Patch Set 16:
(3 comments)
https://review.coreboot.org/c/coreboot/+/35864/16/src/mainboard/lenovo/t60/K... File src/mainboard/lenovo/t60/Kconfig:
https://review.coreboot.org/c/coreboot/+/35864/16/src/mainboard/lenovo/t60/K... PS16, Line 27: config DEVICETREE : string : default "variants/$(CONFIG_VARIANT_DIR)/devicetree.cb" This makes no sense if you use override trees.
https://review.coreboot.org/c/coreboot/+/35864/16/src/mainboard/lenovo/t60/K... PS16, Line 43: default "variants/t60/overridetree.cb" if BOARD_LENOVO_R60 : # R60 uses same files as T60 except gpio.c : default "variants/$(CONFIG_VARIANT_DIR)/overridetree.cb" just make it explicit: default "variant/t60/overridetree.cb" if BOARD_LENOVO_T60 || BOARD_LENOVO_R60
https://review.coreboot.org/c/coreboot/+/35864/16/src/mainboard/lenovo/t60/v... File src/mainboard/lenovo/t60/variants/r60/gpio.c:
https://review.coreboot.org/c/coreboot/+/35864/16/src/mainboard/lenovo/t60/v... PS16, Line 1: /* : * This file is part of the coreboot project. : * : * Copyri neither of these variant/*/gpio.c files are linked...