Attention is currently required from: Hung-Te Lin. build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/60317 )
Change subject: soc/mediatek/mt8186: Add devapc basic drivers ......................................................................
Patch Set 5: Verified+1
(9 comments)
File src/soc/mediatek/mt8186/include/soc/devapc.h:
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-136154): https://review.coreboot.org/c/coreboot/+/60317/comment/699c7a6c_077ab188 PS5, Line 68: #define DAPC_PERM_ATTR_4(DEV_NAME, PERM_ATTR0, PERM_ATTR1, \ Macros with complex values should be enclosed in parentheses
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-136154): https://review.coreboot.org/c/coreboot/+/60317/comment/d2bda50f_bc7c5bd0 PS5, Line 73: #define DAPC_PERM_ATTR_8(DEV_NAME, PERM_ATTR0, PERM_ATTR1, \ Macros with complex values should be enclosed in parentheses
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-136154): https://review.coreboot.org/c/coreboot/+/60317/comment/d85ba17d_b6fd8be7 PS5, Line 81: #define DAPC_PERM_ATTR_16(DEV_NAME, PERM_ATTR0, PERM_ATTR1, \ Macros with complex values should be enclosed in parentheses
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-136154): https://review.coreboot.org/c/coreboot/+/60317/comment/afb8a981_9f5f42d9 PS5, Line 95: #define FORBIDDEN3 FORBIDDEN, FORBIDDEN, FORBIDDEN Macros with complex values should be enclosed in parentheses
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-136154): https://review.coreboot.org/c/coreboot/+/60317/comment/2f5ac0ef_00f31bd4 PS5, Line 96: #define FORBIDDEN4 FORBIDDEN3, FORBIDDEN Macros with complex values should be enclosed in parentheses
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-136154): https://review.coreboot.org/c/coreboot/+/60317/comment/a8b9a26a_06d5ec5b PS5, Line 97: #define FORBIDDEN5 FORBIDDEN4, FORBIDDEN Macros with complex values should be enclosed in parentheses
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-136154): https://review.coreboot.org/c/coreboot/+/60317/comment/fc541d63_f3c2fec9 PS5, Line 98: #define FORBIDDEN6 FORBIDDEN5, FORBIDDEN Macros with complex values should be enclosed in parentheses
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-136154): https://review.coreboot.org/c/coreboot/+/60317/comment/c523595c_a420da3e PS5, Line 99: #define FORBIDDEN7 FORBIDDEN6, FORBIDDEN Macros with complex values should be enclosed in parentheses
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-136154): https://review.coreboot.org/c/coreboot/+/60317/comment/2386440f_d2a5f4f9 PS5, Line 101: #define NO_PROTECTION4 NO_PROTECTION, NO_PROTECTION, NO_PROTECTION, NO_PROTECTION Macros with complex values should be enclosed in parentheses