Patrick Rudolph has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/34541 )
Change subject: soc/intel/cannonlake: Allow coreboot to handle required chipset lockdown
......................................................................
Patch Set 3:
(1 comment)
https://review.coreboot.org/c/coreboot/+/34541/3/src/soc/intel/cannonlake/fs...
File src/soc/intel/cannonlake/fsp_params.c:
https://review.coreboot.org/c/coreboot/+/34541/3/src/soc/intel/cannonlake/fs...
PS3, Line 412: tconfig->PchLockDownGlobalSmi = 0;
: tconfig->PchLockDownBiosInterface = 0;
: params->PchLockDownBiosLock = 0;
: params->PchLockDownRtcMemoryLock = 0;
: /*
Last time i have checked this, those are default enable but i can crosscheck again.
That doesn't even matter.
If someone decides to change the default, it would break here.
It's better to always set those to sane values.
--
To view, visit
https://review.coreboot.org/c/coreboot/+/34541
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I7e53c4e4987a7b0e7f475c92b0f797d94fdd60f4
Gerrit-Change-Number: 34541
Gerrit-PatchSet: 3
Gerrit-Owner: Subrata Banik
subrata.banik@intel.com
Gerrit-Reviewer: Aamir Bohra
aamir.bohra@intel.com
Gerrit-Reviewer: Furquan Shaikh
furquan@google.com
Gerrit-Reviewer: Patrick Rudolph
siro@das-labor.org
Gerrit-Reviewer: Paul Fagerburg
pfagerburg@chromium.org
Gerrit-Reviewer: Shelley Chen
shchen@google.com
Gerrit-Reviewer: Subrata Banik
subrata.banik@intel.com
Gerrit-Reviewer: Tim Wawrzynczak
twawrzynczak@chromium.org
Gerrit-Reviewer: V Sowmya
v.sowmya@intel.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Patrick Rudolph
patrick.rudolph@9elements.com
Gerrit-CC: Paul Menzel
paulepanter@users.sourceforge.net
Gerrit-Comment-Date: Tue, 30 Jul 2019 06:15:41 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Subrata Banik
subrata.banik@intel.com
Comment-In-Reply-To: Furquan Shaikh
furquan@google.com
Gerrit-MessageType: comment