Angel Pons has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/35427 )
Change subject: mb/supermicro/x11: add x11ssm-f board ......................................................................
Patch Set 8:
(5 comments)
https://review.coreboot.org/c/coreboot/+/35427/8/Documentation/mainboard/sup... File Documentation/mainboard/supermicro/x11/ssm-f/x11ssh-tf.md:
https://review.coreboot.org/c/coreboot/+/35427/8/Documentation/mainboard/sup... PS8, Line 12: [Intel FSP2.0] can not be removed as long as there is no free replacement This is basically "FSP 2.0 can't bre removed because nobody bothered to write a replacement"
https://review.coreboot.org/c/coreboot/+/35427/8/Documentation/mainboard/sup... PS8, Line 39: to fail. This fits on the previous line (if the .md files also have a 96-char line length limit)
https://review.coreboot.org/c/coreboot/+/35427/8/src/mainboard/supermicro/x1... File src/mainboard/supermicro/x11-lga1151-series/variants/ssm-f/Kconfig:
https://review.coreboot.org/c/coreboot/+/35427/8/src/mainboard/supermicro/x1... PS8, Line 5: ssm-f I would use the full name: x11ssm-f
https://review.coreboot.org/c/coreboot/+/35427/8/src/mainboard/supermicro/x1... File src/mainboard/supermicro/x11-lga1151-series/variants/ssm-f/devicetree.cb:
https://review.coreboot.org/c/coreboot/+/35427/8/src/mainboard/supermicro/x1... PS8, Line 20: # defaults to 0; datasheet says clkreq# isn't supported for root ports and this is RO; can we drop this then? I guess. At least remove these long comments please :D
https://review.coreboot.org/c/coreboot/+/35427/8/src/mainboard/supermicro/x1... File src/mainboard/supermicro/x11-lga1151-series/variants/ssm-f/todo.txt:
PS8: Move to documentation?