[coreboot-gerrit] Change in coreboot[master]: soc/intel/common/block/cpu: Refactor init_cpus function

[Subrata Banik (Code Review)]

Subrata Banik has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/44076 )

Change subject: soc/intel/common/block/cpu: Refactor init_cpus function
......................................................................

Patch Set 6:

(1 comment)

https://review.coreboot.org/c/coreboot/+/44076/6/src/soc/intel/common/block/... 
File src/soc/intel/common/block/cpu/mp_init.c:

https://review.coreboot.org/c/coreboot/+/44076/6/src/soc/intel/common/block/... 
PS6, Line 149: 
             : 	microcode_patch = intel_microcode_find();
             : 	intel_microcode_load_unlocked(microcode_patch);
> I was actually referring to coreboot applying the microcode update. […]

I believe we have checks inside "src/cpu/intel/microcode/microcode.c" as below to skip if ucode is already loaded. in case FSP is doing MP init, attempting to do ucocde update inside CB, i could see "microcode: Update skipped, already up-to-date" msg in log, hence remove the redundant call inside init_cpus()

vim src/cpu/intel/microcode/microcode.c +59
/* No use loading the same revision. */

if (current_rev == m->rev) {
       printk(BIOS_INFO, "microcode: Update skipped, already up-to-date\n");
       return;
 }

And from log, i could see it skipping the same.

microcode: Update skipped, already up-to-date