Wonkyu Kim has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/43980 )
Change subject: soc/intel/tigerlake: Configure TCSS D3Hot and D3Cold
......................................................................
Patch Set 4: Code-Review+2
Checked it with Google, we'll add condition check in fsp_param.c for now and we'll check again if we can remove the condition by checking stepping info for active varients.
--
To view, visit
https://review.coreboot.org/c/coreboot/+/43980
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I534ddfefcd182f5b35aa5e8b461f0920d375a66d
Gerrit-Change-Number: 43980
Gerrit-PatchSet: 4
Gerrit-Owner: John Zhao
john.zhao@intel.com
Gerrit-Reviewer: Caveh Jalali
caveh@chromium.org
Gerrit-Reviewer: Divya S Sasidharan
divya.s.sasidharan@intel.com
Gerrit-Reviewer: Furquan Shaikh
furquan@google.com
Gerrit-Reviewer: Patrick Rudolph
siro@das-labor.org
Gerrit-Reviewer: Ravishankar Sarawadi
ravishankar.sarawadi@intel.com
Gerrit-Reviewer: Shamile Khan
shamile.khan@intel.com
Gerrit-Reviewer: Shreesh Chhabbi
shreesh.chhabbi@intel.com
Gerrit-Reviewer: Tim Wawrzynczak
twawrzynczak@chromium.org
Gerrit-Reviewer: Wonkyu Kim
wonkyu.kim@intel.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Angel Pons
th3fanbus@gmail.com
Gerrit-Comment-Date: Wed, 29 Jul 2020 22:17:27 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: Yes
Gerrit-MessageType: comment