[coreboot-gerrit] [M] Change in coreboot[master]: amdfwtool: Add --output-manifest option

[Grzegorz Bernacki (Code Review)]

Attention is currently required from: Jason Glenesk, Raul Rangel, Jakub Czapiga, Matt DeVillier, Paul Menzel, Arthur Heymans, Fred Reitberger, Karthik Ramasubramanian, Felix Held.

Grzegorz Bernacki has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/74266 )

Change subject: amdfwtool: Add --output-manifest option
......................................................................

Patch Set 4:

(4 comments)

File util/amdfwtool/amdfwtool.c:

https://review.coreboot.org/c/coreboot/+/74266/comment/6bee3cd8_e2737b38 
PS3, Line 853: fopen(
> Recommend to use open system call to be consistent with the rest of the use-cases in this utility.

Done

https://review.coreboot.org/c/coreboot/+/74266/comment/b13f77d3_2efa0192 
PS3, Line 867: blob_fd = open(index->filename, O_RDONLY);
             : 			read(blob_fd, &hdr, sizeof(hdr));
             : 			fprintf(version_file, "type: 0x%02x ver:%02x.%02x.%02x.%02x\n",
             : 			    index->type, hdr.version[3], hdr.version[2],
             : 			    hdr.version[1], hdr.version[0]);
             : 			close(blob_fd);
> You can add a function pointer/callback and a human-readable name of the binary into amd_fw_entry. […]

Done

https://review.coreboot.org/c/coreboot/+/74266/comment/276c98e2_bf9698fa 
PS3, Line 1509: _SIG
> _SIG suffix not required.

Done

https://review.coreboot.org/c/coreboot/+/74266/comment/0bd482e5_fb0d8728 
PS3, Line 2145: if (manifest_file) {
              : 		dump_blob_version(manifest_file, amd_psp_fw_table);
              : 	}
> This can be done before the amdfw_tool_cleanup. There is nothing in keeping it here. […]

Done