7 Nov
2019
7 Nov
'19
2:46 p.m.
Arthur Heymans has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/36104 )
Change subject: util/docker/Makefile: Add documentation docker image targets ......................................................................
Patch Set 3:
(1 comment)
https://review.coreboot.org/c/coreboot/+/36104/2/util/docker/Makefile File util/docker/Makefile:
https://review.coreboot.org/c/coreboot/+/36104/2/util/docker/Makefile@173 PS2, Line 173: docker-build-docs: test-docker
should these targets depend on the doc.coreboot.org target so the image gets built?
It's a phony, so no?
--
To view, visit https://review.coreboot.org/c/coreboot/+/36104
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: Ic07f216f8d90d6e212383250b852dc91575304c3
Gerrit-Change-Number: 36104
Gerrit-PatchSet: 3
Gerrit-Owner: Arthur Heymans arthur@aheymans.xyz
Gerrit-Reviewer: Arthur Heymans arthur@aheymans.xyz
Gerrit-Reviewer: Martin Roth martinroth@google.com
Gerrit-Reviewer: Patrick Georgi pgeorgi@google.com
Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org
Gerrit-Comment-Date: Thu, 07 Nov 2019 22:46:38 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Patrick Georgi pgeorgi@google.com
Gerrit-MessageType: comment