[coreboot-gerrit] [XS] Change in coreboot[main]: mb/sifive/hifive-unleashed: Disable SEPARATE_ROMSTAGE

[Arthur Heymans (Code Review)]

Attention is currently required from: Maximilian Brune, Nico Huber, Philipp Hug, ron minnich.

Arthur Heymans has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/81910?usp=email )

Change subject: mb/sifive/hifive-unleashed: Disable SEPARATE_ROMSTAGE
......................................................................

Patch Set 1:

(1 comment)

Commit Message:

https://review.coreboot.org/c/coreboot/+/81910/comment/71f0c383_92087751 :
PS1, Line 18: The coreboot LZ4 decompression code does some misaligned access during
            : decompression
> I don't know how deep this rabbit hole goes, but wouldn't it be
> better to fix the code? AIUI, unaligned accesses are less efficient
> but decompression should be most performant?

Best of both worlds: use bootblock with decompressor stage without a separate romstage? Still it might be desirable to have a separate romstage in the VBOOT use case?

About the misaligned access: is  -mstrict-align passed to the compiler?