Attention is currently required from: Philipp Deppenwiese, Jonathan Zhang, Johnny Lin, Arthur Heymans, Deomid "rojer" Ryabkov.
Julius Werner has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/51099 )
Change subject: lib/cbfs.c: Fix return value of failure to measure
......................................................................
Patch Set 1:
(1 comment)
Patchset:
PS1:
Or do it get it wrong? Is the TPM doing nothing or is there a cbfs error?
This error case is most likely a TPM communication issue or something like that, it's not really related to the CBFS file. So if you can't extend the real file hash here, chances are you probably can't extend anything else either. You can only ignore it or die().
--
To view, visit
https://review.coreboot.org/c/coreboot/+/51099
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: Ifd20e543d3b30de045c0656eccdcc494c2fb10ce
Gerrit-Change-Number: 51099
Gerrit-PatchSet: 1
Gerrit-Owner: Arthur Heymans
arthur@aheymans.xyz
Gerrit-Reviewer: Deomid "rojer" Ryabkov
rojer9@fb.com
Gerrit-Reviewer: Johnny Lin
Johnny_Lin@wiwynn.com
Gerrit-Reviewer: Julius Werner
jwerner@chromium.org
Gerrit-Reviewer: Philipp Deppenwiese
zaolin.daisuki@gmail.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Jonathan Zhang
jonzhang@fb.com
Gerrit-CC: Paul Menzel
paulepanter@users.sourceforge.net
Gerrit-Attention: Philipp Deppenwiese
zaolin.daisuki@gmail.com
Gerrit-Attention: Jonathan Zhang
jonzhang@fb.com
Gerrit-Attention: Johnny Lin
Johnny_Lin@wiwynn.com
Gerrit-Attention: Arthur Heymans
arthur@aheymans.xyz
Gerrit-Attention: Deomid "rojer" Ryabkov
rojer9@fb.com
Gerrit-Comment-Date: Tue, 02 Mar 2021 00:40:22 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Philipp Deppenwiese
zaolin.daisuki@gmail.com
Gerrit-MessageType: comment