Attention is currently required from: Martin Roth, Matt DeVillier, Tim Wawrzynczak. Paul Menzel has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/62796 )
Change subject: x86/smbios_defaults: Set default system manufacturer for ChromeOS devices ......................................................................
Patch Set 1: Code-Review+1
(3 comments)
Commit Message:
https://review.coreboot.org/c/coreboot/+/62796/comment/5979645f_37855171 PS1, Line 14: This breaks many DMI quirks, notably ones used by SOF (sound : open firmware) for audio. Do you know of the Chromium OS Linux kernel commit making this work for Chromium OS?
https://review.coreboot.org/c/coreboot/+/62796/comment/554bf137_03b1ad1a PS1, Line 9: Currently, many Linux drivers use DMI quirks to identify ChromeOS devices and : handle them accordingly: namely they look for the SMBIOS system manufactuer : to be "GOOGLE" or "Google", and the bios-vendor to be coreboot. Historically : this was consistently the case, but recent model ChromeOS devices allow the : OEM to set the mainboard manufacturer, which is also the default system : manufacturer. This breaks many DMI quirks, notably ones used by SOF (sound : open firmware) for audio. Please reflow for 72 characters per line.
File src/arch/x86/smbios_defaults.c:
https://review.coreboot.org/c/coreboot/+/62796/comment/b26d4657_a55f9bae PS1, Line 121: return smbios_mainboard_manufacturer(); You could you the ternary operator, use the if statement, and also add a log message, that it’s overwritten.