Attention is currently required from: Angel Pons, Arthur Heymans, Evgeny Zinoviev, Patrick Rudolph.
Nico Huber has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/49996 )
Change subject: sb/intel/bd82x6x: Do CPU replacement check before raminit
......................................................................
Patch Set 10: Code-Review-1
(2 comments)
Patchset:
PS5:
As I said in the commit message, still works.
Ignoring the loop, there are 4 paths alone in intel_early_
me_cpu_replacement_check(). The commit message suggests
to me that 1 was tested.
Patchset:
PS10:
Really sorry. But doesn't this break the MRC path?
--
To view, visit
https://review.coreboot.org/c/coreboot/+/49996
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: Id78ac9bc3ca2c1724937e2669bec6d7d5827fd0c
Gerrit-Change-Number: 49996
Gerrit-PatchSet: 10
Gerrit-Owner: Angel Pons
th3fanbus@gmail.com
Gerrit-Reviewer: Arthur Heymans
arthur@aheymans.xyz
Gerrit-Reviewer: Evgeny Zinoviev
me@ch1p.io
Gerrit-Reviewer: Nico Huber
nico.h@gmx.de
Gerrit-Reviewer: Patrick Rudolph
patrick.rudolph@9elements.com
Gerrit-Reviewer: Patrick Rudolph
siro@das-labor.org
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-Attention: Angel Pons
th3fanbus@gmail.com
Gerrit-Attention: Arthur Heymans
arthur@aheymans.xyz
Gerrit-Attention: Evgeny Zinoviev
me@ch1p.io
Gerrit-Attention: Patrick Rudolph
siro@das-labor.org
Gerrit-Comment-Date: Fri, 26 Feb 2021 14:16:47 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
Comment-In-Reply-To: Angel Pons
th3fanbus@gmail.com
Comment-In-Reply-To: Patrick Rudolph
siro@das-labor.org
Gerrit-MessageType: comment