[coreboot-gerrit] Change in coreboot[master]: soc/amd/cezanne: Add ability to dump Smart Trace Buffer in bootblock

[Felix Held (Code Review)]

Attention is currently required from: Jason Glenesk, Raul Rangel, Marshall Dawson.
Felix Held has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/61690 )

Change subject: soc/amd/cezanne: Add ability to dump Smart Trace Buffer in bootblock
......................................................................

Patch Set 3:

(2 comments)

File src/soc/amd/cezanne/stb.c:

PS3: 
since this is likely common code, it would be good to move it to soc/amd/common/block/stb

https://review.coreboot.org/c/coreboot/+/61690/comment/cb6c8193_b66ee5fd 
PS3, Line 9: #define AMD_PMC_STB_INDEX_ADDRESS	0xF8
           : #define AMD_PMC_STB_INDEX_DATA		0xFC
hmm. can we use the existing smn read and write functions instead?