Karthik Ramasubramanian has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/43277 )
Change subject: mb/mainboard/dedede: update GPIO table for Boten
......................................................................
Patch Set 1:
(1 comment)
https://review.coreboot.org/c/coreboot/+/43277/1/src/mainboard/google/dedede...
File src/mainboard/google/dedede/variants/boten/gpio.c:
https://review.coreboot.org/c/coreboot/+/43277/1/src/mainboard/google/dedede...
PS1, Line 9: pad_config gpio_table[]
I dont think all the GPIOs are different compared to the baseboard. If so, override only those GPIOs that are different.
Kindly allow me a day so that I can upload the CL that will enable you to add only override entries.
--
To view, visit
https://review.coreboot.org/c/coreboot/+/43277
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I4eafee608f657f8ec5a06caf6e99b08b3330512b
Gerrit-Change-Number: 43277
Gerrit-PatchSet: 1
Gerrit-Owner: Yan Liu
yan.liu@bitland.corp-partner.google.com
Gerrit-Reviewer: Furquan Shaikh
furquan@google.com
Gerrit-Reviewer: Karthik Ramasubramanian
kramasub@google.com
Gerrit-Reviewer: Martin Roth
martinroth@google.com
Gerrit-Reviewer: Patrick Georgi
pgeorgi@google.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-Comment-Date: Wed, 08 Jul 2020 04:11:51 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment