Martin Roth has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/44538 )
Change subject: soc/amd/picasso: Reboot for recovery if no psp workbuf is found ......................................................................
Patch Set 1:
(4 comments)
https://review.coreboot.org/c/coreboot/+/44538/1//COMMIT_MSG Commit Message:
https://review.coreboot.org/c/coreboot/+/44538/1//COMMIT_MSG@14 PS1, Line 14: needed for that process
you should elaborate as to why
Done
https://review.coreboot.org/c/coreboot/+/44538/1/src/soc/amd/picasso/Kconfig File src/soc/amd/picasso/Kconfig:
https://review.coreboot.org/c/coreboot/+/44538/1/src/soc/amd/picasso/Kconfig... PS1, Line 510: 0x6F
I looked at the cmos values that were currently in use to avoid those. […]
Sorry, we use 0x52 as the default location of VBNV. I grabbed the wrong section that we were using. The block at 0x70 is used for saving the CMOS POST values. Changed to 0x51 and added a comment about why that value is used.
https://review.coreboot.org/c/coreboot/+/44538/1/src/soc/amd/picasso/include... File src/soc/amd/picasso/include/soc/psp_transfer.h:
https://review.coreboot.org/c/coreboot/+/44538/1/src/soc/amd/picasso/include... PS1, Line 12: 0x96
The value is completely arbitrary. […]
Changed macro name to CMOS_RECOVERY_MAGIC_VAL. I left it at 0x96 unless there's a value that you'd prefer.
https://review.coreboot.org/c/coreboot/+/44538/1/src/soc/amd/picasso/psp_ver... File src/soc/amd/picasso/psp_verstage/psp_verstage.c:
https://review.coreboot.org/c/coreboot/+/44538/1/src/soc/amd/picasso/psp_ver... PS1, Line 234: if (retval)
Thanks. Yes, there should be a "goto err;" there. […]
Done