Edward O'Callaghan has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/38003 )
Change subject: mainboard/google/puff: Enable net driver on pcie ep ......................................................................
Patch Set 5:
(1 comment)
https://review.coreboot.org/c/coreboot/+/38003/5/src/mainboard/google/hatch/... File src/mainboard/google/hatch/variants/puff/overridetree.cb:
https://review.coreboot.org/c/coreboot/+/38003/5/src/mainboard/google/hatch/... PS5, Line 183: chip drivers/net : register "customized_leds" = "0x05af" : device pci 00.0 on end : end
This should not be done. […]
What is https://review.coreboot.org/c/coreboot/+/36651 all about? Looks unfinished currently?
Yes, see my prior change put it on port7 however it didn't work which why I quested this a lot with other folks.
In any case I believe we found the underlying reason in that a clk was off in ME, specifically ClkoutSRC0, which took us some time to trace down. I'll try moving it back again once that change is merged.
The NIC issue is still WIP however thanks for the comment.