Paul Menzel has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/41442 )
Change subject: device: Move resource allocation into a separate compilation unit
......................................................................
Patch Set 11:
This commit 69395742b8 fails with the error below when building coreboot for the Lenovo T60:
x86_64-linux-gnu-ld.bfd: build/generated/ramstage.o: in function `dev_configure':
/dev/shm/coreboot/src/device/device.c:477: undefined reference to `allocate_resources'
--
To view, visit
https://review.coreboot.org/c/coreboot/+/41442
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I2f5440cf83c6e9e15a5f22e79cc3c66aa2cec4c0
Gerrit-Change-Number: 41442
Gerrit-PatchSet: 11
Gerrit-Owner: Furquan Shaikh
furquan@google.com
Gerrit-Reviewer: Aaron Durbin
adurbin@chromium.org
Gerrit-Reviewer: Angel Pons
th3fanbus@gmail.com
Gerrit-Reviewer: HAOUAS Elyes
ehaouas@noos.fr
Gerrit-Reviewer: Martin Roth
martinroth@google.com
Gerrit-Reviewer: Mike Banon
mikebdp2@gmail.com
Gerrit-Reviewer: Nico Huber
nico.h@gmx.de
Gerrit-Reviewer: Patrick Georgi
pgeorgi@google.com
Gerrit-Reviewer: Paul Menzel
paulepanter@users.sourceforge.net
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: 9elements QA
hardwaretestrobot@gmail.com
Gerrit-Comment-Date: Sat, 18 Jul 2020 07:18:41 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: No
Gerrit-MessageType: comment