Richard Spiegel has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/31420 )
Change subject: SMBIOS: Update Processor Information structure to v3.2.0 ......................................................................
Patch Set 7:
(1 comment)
https://review.coreboot.org/#/c/31420/7/src/arch/x86/smbios.c File src/arch/x86/smbios.c:
https://review.coreboot.org/#/c/31420/7/src/arch/x86/smbios.c@565 PS7, Line 565: t->core_count2 = t->core_count; Shouldn't you add code that once the number of cores are truly know and found to be greater then 255,to update core_count to 0xff and core_count2 with the correct number? Actually, by the time that tables are written (one of the last things before loading OS, number of cores should already be known. I'm not sure where and if this number is stored, but if it's not yet being stored you should add a separate commit to store this number, and than use it here. OTOH, I'm not sure if currently there is any platform using coreboot that has more than 255 cores (usually a server), so maybe this can wait? Nico, any thoughts?