3 Oct
2020
3 Oct
'20
5:26 p.m.
Angel Pons has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/45975 )
Change subject: soc/intel/common/block/acpi: Factor out common pch_glan.asl ......................................................................
Patch Set 1: Code-Review+1
(1 comment)
https://review.coreboot.org/c/coreboot/+/45975/1/src/soc/intel/elkhartlake/a... File src/soc/intel/elkhartlake/acpi/southbridge.asl:
https://review.coreboot.org/c/coreboot/+/45975/1/src/soc/intel/elkhartlake/a... PS1, Line 47: GBe nit: GbE
Also, EHL didn't include the file before. Does it matter?
--
To view, visit https://review.coreboot.org/c/coreboot/+/45975
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I479678c864eba39e5ab04f658600e8cba48198ef
Gerrit-Change-Number: 45975
Gerrit-PatchSet: 1
Gerrit-Owner: Subrata Banik subrata.banik@intel.com
Gerrit-Reviewer: Angel Pons th3fanbus@gmail.com
Gerrit-Reviewer: Furquan Shaikh furquan@google.com
Gerrit-Reviewer: Patrick Rudolph siro@das-labor.org
Gerrit-Reviewer: Tim Wawrzynczak twawrzynczak@chromium.org
Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org
Gerrit-CC: Subrata Banik subi.banik@gmail.com
Gerrit-Comment-Date: Sat, 03 Oct 2020 15:26:02 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
Gerrit-MessageType: comment