Nico Huber has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/34157 )
Change subject: soc/intel/cannonlake: Add device Ids for new CFL SKUs support ......................................................................
Patch Set 15:
(1 comment)
https://review.coreboot.org/c/coreboot/+/34157/8/src/include/device/pci_ids.... File src/include/device/pci_ids.h:
https://review.coreboot.org/c/coreboot/+/34157/8/src/include/device/pci_ids.... PS8, Line 3219: #define PCH_CNP_H_MOBILE_C246 0xa309
DT stands for desktop. […]
DT is ambiguous (usually refers to Intel's "Workstation or Entry Level Server"). If the above H_DT_SUPER is supposed to mean that or if the person who wrote it was confused, too, idk. The problem with DT in Intel's documentation is that it didn't reach the marke- ting names. Hence, it's harder to find what it actually means.
But honestly it doesn't matter. If Intel developers can't figure out that MOBILE_Q370 is wrong (because Q370 is a desktop chipset) and MOBILE_C246 is wrong (because C246 is a desktop chipset) without the help of non-Intel developers, then Intel developers shouldn't write patches that add PCI IDs like this. Hint hint: the M in CM and QM seems to stand indeed for `mobile`.