Attention is currently required from: CoolStar, Felix Held, Jason Nien, Jon Murphy, Martin Roth, Matt DeVillier, Nico Huber, Paul Menzel.
Raul Rangel has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/75874?usp=email )
Change subject: mb/google/kahlee: Enable Secure OS
......................................................................
Patch Set 7: Code-Review+1
(1 comment)
File src/mainboard/google/kahlee/Kconfig:
https://review.coreboot.org/c/coreboot/+/75874/comment/b082ff0a_0a8f4fa0 :
PS7, Line 149: config USE_PSPSECUREOS
: def_bool n if CHROMEOS
: def_bool y
nit: I guess we should only define the type one:
```
config USE_PSPSECUREOS
bool
default n if CHROMEOS
default y
```
--
To view, visit
https://review.coreboot.org/c/coreboot/+/75874?usp=email
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I213aebc41cae300ecee8c01fc5c7687f7e7f5ee3
Gerrit-Change-Number: 75874
Gerrit-PatchSet: 7
Gerrit-Owner: Jon Murphy
jpmurphy@google.com
Gerrit-Reviewer: CoolStar
coolstarorganization@gmail.com
Gerrit-Reviewer: Jason Nien
jason.nien@amd.corp-partner.google.com
Gerrit-Reviewer: Martin Roth
martin.roth@amd.corp-partner.google.com
Gerrit-Reviewer: Matt DeVillier
matt.devillier@gmail.com
Gerrit-Reviewer: Nico Huber
nico.h@gmx.de
Gerrit-Reviewer: Raul Rangel
rrangel@chromium.org
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Felix Held
felix-coreboot@felixheld.de
Gerrit-CC: Paul Menzel
paulepanter@mailbox.org
Gerrit-Attention: Nico Huber
nico.h@gmx.de
Gerrit-Attention: Jason Nien
jason.nien@amd.corp-partner.google.com
Gerrit-Attention: Matt DeVillier
matt.devillier@gmail.com
Gerrit-Attention: Jon Murphy
jpmurphy@google.com
Gerrit-Attention: Paul Menzel
paulepanter@mailbox.org
Gerrit-Attention: CoolStar
coolstarorganization@gmail.com
Gerrit-Attention: Martin Roth
martin.roth@amd.corp-partner.google.com
Gerrit-Attention: Felix Held
felix-coreboot@felixheld.de
Gerrit-Comment-Date: Wed, 28 Jun 2023 17:11:31 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
Gerrit-MessageType: comment