Kyösti Mälkki has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/31357 )
Change subject: src/mainboard/lenovo/g505s: Disable SeaBIOS options not supported by hardware
......................................................................
Patch Set 6:
Patch Set 6:
Sadly there is no progress in the review of G505S patches, despite their great significance:
You do reviews; you get reviews. And don't get offended when your particular solution is not merged as-is.
I thought there was a conclusion AMD / AtomBIOS only has to be loaded (from OS driver perspective), and the memory location of said blob filled in ACPI. If your proposal always forced running them, that's probably the reason for no-further-review and no merge, if that's what happened.
Did I miss work that only loads the discrete AtomBIOS tables?
--
To view, visit
https://review.coreboot.org/c/coreboot/+/31357
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I5b2ee6403d7d2298725729d8d833e37627a4f202
Gerrit-Change-Number: 31357
Gerrit-PatchSet: 6
Gerrit-Owner: mikeb mikeb
mikebdp2@gmail.com
Gerrit-Reviewer: Alexander Couzens
lynxis@fe80.eu
Gerrit-Reviewer: Angel Pons
th3fanbus@gmail.com
Gerrit-Reviewer: Kyösti Mälkki
kyosti.malkki@gmail.com
Gerrit-Reviewer: Mike Banon
mikebdp2@gmail.com
Gerrit-Reviewer: Patrick Rudolph
siro@das-labor.org
Gerrit-Reviewer: Paul Menzel
paulepanter@users.sourceforge.net
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-Reviewer: mikeb mikeb
mikebdp2@gmail.com
Gerrit-Comment-Date: Sat, 16 Mar 2019 16:40:30 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: No
Gerrit-MessageType: comment