Attention is currently required from: Dinesh Gehlot, Eric Lai, Jayvik Desai, Kapil Porwal, Nick Vaccaro, Subrata Banik.
Kun Liu has posted comments on this change by Kun Liu. ( https://review.coreboot.org/c/coreboot/+/85738?usp=email )
Change subject: mb/google/nissa/var/telith: Disable stylus function
......................................................................
Patch Set 2:
(1 comment)
File src/mainboard/google/brya/variants/telith/gpio.c:
https://review.coreboot.org/c/coreboot/+/85738/comment/0f64dde1_3e7be66f?usp... :
PS2, Line 46: PAD_CFG_GPO
Why GPO and not NC?
Because the external environment is floating, EE requires setting GPIO output to be pulled high or low
--
To view, visit
https://review.coreboot.org/c/coreboot/+/85738?usp=email
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings?usp=email
Gerrit-MessageType: comment
Gerrit-Project: coreboot
Gerrit-Branch: main
Gerrit-Change-Id: I7b72284ab173633405d5de9541f0ea7520d09658
Gerrit-Change-Number: 85738
Gerrit-PatchSet: 2
Gerrit-Owner: Kun Liu
liukun11@huaqin.corp-partner.google.com
Gerrit-Reviewer: Dinesh Gehlot
digehlot@google.com
Gerrit-Reviewer: Eric Lai
ericllai@google.com
Gerrit-Reviewer: Jayvik Desai
jayvik@google.com
Gerrit-Reviewer: Kapil Porwal
kapilporwal@google.com
Gerrit-Reviewer: Nick Vaccaro
nvaccaro@chromium.org
Gerrit-Reviewer: Rui Zhou
zhourui@huaqin.corp-partner.google.com
Gerrit-Reviewer: Subrata Banik
subratabanik@google.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-Attention: Jayvik Desai
jayvik@google.com
Gerrit-Attention: Eric Lai
ericllai@google.com
Gerrit-Attention: Subrata Banik
subratabanik@google.com
Gerrit-Attention: Kapil Porwal
kapilporwal@google.com
Gerrit-Attention: Dinesh Gehlot
digehlot@google.com
Gerrit-Attention: Nick Vaccaro
nvaccaro@chromium.org
Gerrit-Comment-Date: Mon, 23 Dec 2024 11:01:27 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Kapil Porwal
kapilporwal@google.com